[
https://issues.apache.org/jira/browse/FREEMARKER-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042480#comment-17042480
]
Dániel Dékány commented on FREEMARKER-133:
------------------------------------------
I still can't see what causes the problem. There's a
{{Map<signature,methodList>}} of *accessible* methods, from which FreeMarker
selects the methods it will expose. That's also what you have seen used in
{{getMatchingAccessibleMethod}}; it chooses from methods that were already
deemed to be accessible. Public methods that are overridden (or first
implemented) in a non-public class arent' among the accessible methods (see
{{BeansIntrospector.discoverAccessibleMethods}}). {{AbstractListMultimap}} is
not public, and it overrides {{get}}, so that method couldn't be called, but
that method shouldn't be among the accessible method either. But do you see
{{BeansInropsector}} picking {{AbstractListMultimap.get}}? Above I only see
{{ListMultimap.get}}, which is in a public class (in Guava master branch at
least), and therefore should be callable.
> BeansWrapper IllegalAccessException when class defining accessed method is
> package-private, but subclass is public
> ------------------------------------------------------------------------------------------------------------------
>
> Key: FREEMARKER-133
> URL: https://issues.apache.org/jira/browse/FREEMARKER-133
> Project: Apache Freemarker
> Issue Type: Bug
> Reporter: Lauri Keel
> Priority: Major
>
> Consider the following code:
> {code:java}
> <#list orders.get(type) as order></#list>{code}
> where orders is com.google.common.collect.ArrayListMultimap. An
> IllegalAccessException is thrown, because
> com.google.common.collect.AbstractListMultimap where the get method is
> defined is package-private.
> {code:java}
> ----
> FTL stack trace ("~" means nesting-related):
> - Failed at: #list orders.get(type) as order [in template
> "admin-orders.ftl" at line 4, column 9]
> ----
> at
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:289)
> at
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:252)
> at
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:77)
> at freemarker.core.MethodCall._eval(MethodCall.java:65)
> at freemarker.core.Expression.eval(Expression.java:83)
> at
> freemarker.core.IteratorBlock.acceptWithResult(IteratorBlock.java:98)
> at freemarker.core.IteratorBlock.accept(IteratorBlock.java:93)
> at freemarker.core.Environment.visit(Environment.java:366)
> at
> freemarker.core.IteratorBlock$IterationContext.executedNestedContentForCollOrSeqListing(IteratorBlock.java:291)
> at
> freemarker.core.IteratorBlock$IterationContext.executeNestedContent(IteratorBlock.java:271)
> at
> freemarker.core.IteratorBlock$IterationContext.accept(IteratorBlock.java:242)
> at
> freemarker.core.Environment.visitIteratorBlock(Environment.java:642)
> at
> freemarker.core.IteratorBlock.acceptWithResult(IteratorBlock.java:107)
> at freemarker.core.IteratorBlock.accept(IteratorBlock.java:93)
> at freemarker.core.Environment.visit(Environment.java:330)
> at freemarker.core.Environment.visit(Environment.java:336)
> at freemarker.core.Environment.process(Environment.java:309)
> at freemarker.template.Template.process(Template.java:384)
> at puu.page.PageHandler.getRendered(PageHandler.java:550)
> ... 36 common frames omitted
> Caused by: java.lang.IllegalAccessException: class
> freemarker.ext.beans.BeansWrapper cannot access a member of class
> com.google.common.collect.AbstractListMultimap with modifiers "public
> volatile"
> at
> java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361)
> at
> java.base/java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:591)
> at java.base/java.lang.reflect.Method.invoke(Method.java:558)
> at
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1505)
> at
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:72)
> ... 52 common frames omitted
> {code}
> Tested in 2.3.29, 2.3.28, 2.3.23. Strangely it occasionally randomly does
> work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
