[ 
https://issues.apache.org/jira/browse/FREEMARKER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207719#comment-17207719
 ] 

Dániel Dékány commented on FREEMARKER-159:
------------------------------------------

Good point. But in the PR you have chosen {{org.freemarker}} as the module 
name. I believe what Java 9 deduces is usually {{freemarker}} (because usually 
you have something like {{freemarker-2.3.30.jar}}). Then we should pin it to be 
{{freemarker}}, for backward compatibility. I know it's not a good module name, 
but we shouldn't break applications that relied on the deduced module name be 
{{freemarker}}, even maybe without realizing that.

> Incompatible with Java modularization
> -------------------------------------
>
>                 Key: FREEMARKER-159
>                 URL: https://issues.apache.org/jira/browse/FREEMARKER-159
>             Project: Apache Freemarker
>          Issue Type: Bug
>    Affects Versions: 2.3.30
>            Reporter: Stefan Huber
>            Priority: Major
>              Labels: easyfix
>   Original Estimate: 1h
>          Time Spent: 20m
>  Remaining Estimate: 40m
>
> Since freemarkers MANIFEST.MF does not contain the `Automatic-Module-Name` 
> directive it can not be used in any modularized project yielding the error:
> {code:java}
> <path>\src\main\java\module-info.java:10: error: module not found: freemarker
>     requires freemarker;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to