hboutemy commented on code in PR #96: URL: https://github.com/apache/freemarker/pull/96#discussion_r1379748118
########## pom.xml: ########## @@ -0,0 +1,455 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <!-- for more information, see the documentation of this POM: https://maven.apache.org/pom/maven/ --> + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>30</version> + </parent> + + <groupId>org.apache.freemarker</groupId> Review Comment: why change the groupId? it's not necessary nor useful for this step please focus this PR to the minimal changes: one PR per topic ########## ivysettings.xml: ########## @@ -33,7 +33,7 @@ <ivy pattern="${localMaveRepoDir}/[organisation]/[module]/[revision]/[module]-[revision].pom" /> </filesystem> --> - <ibiblio name="mavenCentral" m2compatible="true" /> + <ibiblio name="mavenCentral" m2compatible="true" root="https://nexus.intern/repository/central/"; /> Review Comment: what is this root="https://nexus.intern/repository/central/";? it feels like a personal setup: is it really expected to be shared? ########## pom.xml: ########## @@ -0,0 +1,455 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <!-- for more information, see the documentation of this POM: https://maven.apache.org/pom/maven/ --> + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>30</version> + </parent> + + <groupId>org.apache.freemarker</groupId> + <artifactId>freemarker</artifactId> + <version>2.3.33-SNAPSHOT</version> + <packaging>jar</packaging> + + <name>Apache Freemarker</name> + + <description>FreeMarker is a "template engine"; a generic tool to + generate text output (anything from HTML to autogenerated source + code) based on templates.</description> + <url>https://freemarker.apache.org/</url> + <inceptionYear>2000</inceptionYear> + + + <properties> + <javaVersion>8</javaVersion> Review Comment: is it absolutely necessary top switch to Java 8 in this PR? again, this PR should have minimal impact on the output vs previous build: changing prerequisite JDK is a future topic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
