bmarwell commented on PR #98: URL: https://github.com/apache/freemarker/pull/98#issuecomment-1793432669
> But it was released with "Automatic-Module-Name: freemarker" already. Oh, dang. I missed that. :( > The module name was "freemarker" because, as far as I remember, in Java 9, if you had no explicit module name, it was deduced from the jar name, and was "freemarker". While this is true, this would not have been a problem and a reason to use `freemarker` as the automatic-module-name. Whenever you build something with gradle or maven which uses "requires module-name-from-file-name", it gives a BIG warning not to push something like this into the wild. Thus, no-one could have used it. The moment someone renames the `freemarker.jar` locally, it would break. Hence, having set the module-name to something else would not had hurt back then. > (Also that happens to be the top-level Java package name.) See issue. for JPMS, it is even more strongly encouraged to use a reverse domain name. So then I will rebase this to the 3-branch. Or maybe even to the 2.4-branch, if you agree? WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
