[ 
https://issues.apache.org/jira/browse/FREEMARKER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782878#comment-17782878
 ] 

Dániel Dékány commented on FREEMARKER-222:
------------------------------------------

I understand, that reverse DNS is the best practice, but not following that 
doesn't break anything, right?

FreeMarker was already released with {{Automatic-Module-Name: freemarker}} 
previously (like check 2.3.32). The reason it had that name instead of 
{{org.apache.freemarker}}, is that Java 9 did chose that name already, based on 
the jar name, before {{Automatic-Module-Name}} was there. Also, it's consistent 
with equally dated the Java package name, which is also just {{freemarker}}. 
So... that's why.

> JPMS still does not work as expected
> ------------------------------------
>
>                 Key: FREEMARKER-222
>                 URL: https://issues.apache.org/jira/browse/FREEMARKER-222
>             Project: Apache Freemarker
>          Issue Type: Bug
>          Components: engine
>    Affects Versions: 2.3.32
>            Reporter: Benjamin Marwell
>            Priority: Major
>         Attachments: Screenshot 2023-10-25 at 23.02.21.png
>
>
> The issue and PR from FREEMARKER-159 did not seem to be enough.
> See image attached.
> The MANIFEST.MF still states:
> {code:java}
> Automatic-Module-Name: freemarker
> {code}
>  !Screenshot 2023-10-25 at 23.02.21.png! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to