kelemen commented on PR #79: URL: https://github.com/apache/freemarker/pull/79#issuecomment-1865025330
I did some deeper checks on the output of the Gradle build by comparing it to the output of the Ant build. The differences are the following: - OSGi manifest entry differences due to the newer version of bnd being used as described previously. - The `Include-Resource` manifest key have different value, but to be honest, I think this manifest entry does not make any sense in any case (I don't know why bnd adds it). - There are a couple manifest attributes that I did not add: `DSTAMP`, `TODAY`, `TSAMP`. I'm not sure what step of the Ant builds adds these, but I can't really see the value in adding them. That said, they are trivial to add, if neccesary. - As described in the opening comment of the PR, I have added a couple of package private `SuppressFBWarnings` classes to avoid the need to preprocess the source files. While this would be possible to do, but it could potentially fool IDEs and up-to-date checks. - The generated class files are not exactly the same, because - if I understood the Ant build correctly - the Ant build uses the javac of JDK 16, just replaces the boot class path to compile most of the sources, while in this Gradle build I'm compiling those files with the javac of JDK 8. It would be technically possible to do the same in Gradle, but I'm not sure that it would be possible to tell the IDE then what is going on exactly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
