[ https://issues.apache.org/jira/browse/FREEMARKER-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916068#comment-17916068 ]
Matteo Franci commented on FREEMARKER-229: ------------------------------------------ [~ddekany] I had a last review to the pull request. I was also thinking, maybe it is possible to further improve the CI by adding a run on linux arm platform as they are now available for public repositories : https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ Here is an example : [https://github.com/fugerit-org/freemarker/actions/runs/12910088870] Should I add it? It would be especially useful for the native test (as the native executable is different on each platform). See you > Add GraalVM native support for Apache FreeMarker > ------------------------------------------------ > > Key: FREEMARKER-229 > URL: https://issues.apache.org/jira/browse/FREEMARKER-229 > Project: Apache Freemarker > Issue Type: New Feature > Reporter: Matteo Franci > Priority: Minor > Attachments: image-2025-01-15-16-43-13-865.png > > > First of all I want to thank you for the great work on Apache FreeMarker. The > team I work with and I have been using on many projects. > As we are using more and more GraalVM native applications in our team, It > would be nice to have some sort of built-in support. > Currently I only found a community support on [GraalVM reachbility > metadata.|https://github.com/oracle/graalvm-reachability-metadata/blob/master/metadata/org.freemarker/freemarker/index.json] > So I created a github repo we are using to add GraalVM support to projects : > [https://github.com/fugerit-org/freemarker-native] > NOTE: main limitations is that requires java 11+ because of [GraalVM SDK > Substitute > Annotation|https://www.graalvm.org/sdk/javadoc/com/oracle/svm/core/annotate/Substitute.html]. > this is needed to fix missing org.apache.log4j.MDC class in > [https://github.com/apache/freemarker/blob/v2.3.34/freemarker-core/src/main/java/freemarker/log/_Log4jOverSLF4JTester.java#L35] > I had a look at the main repository : > [https://github.com/apache/freemarker/tree/2.3-gae] > And maybe it is possible to include all the necessary changes in it, or build > a "native support" module, alongside the main distribution. > What do you think? > If I can help you anyway I'm here. > Thanks in advance. > NOTE: here you can find more details on how GraalVM support has been added > [https://github.com/fugerit-org/freemarker-native/blob/main/src/main/docs/native-support/index.adoc] > . -- This message was sent by Atlassian Jira (v8.20.10#820010)