[ https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053439#comment-16053439 ]
Woonsan Ko edited comment on FREEMARKER-54 at 6/19/17 4:54 AM: --------------------------------------------------------------- Thanks for the pointer! I've corrected the following: - {{#setSettings(Map)}} was removed as {{#setSetting(Properties)}} is totally fine in spring (ref: bean definition example in commented block in unit test). - Corrected logging in {{SpringResourceTemplateLoader}}. - Added {{VersionEditor}} for Spring because it's more convenient to set by string in XML bean definitions. (See "FooEditor" example in \[1\] for reference.) - Added {{baseLocation}} property in {{SpringResourceTemplateLoader}} for convenience. Since this PR includes {{VersionEditor}} in core, please take a review. Regards, Woonsan \[1\] https://docs.spring.io/spring/docs/current/spring-framework-reference/html/validation.html#beans-beans-conversion was (Author: woon_san): Thanks for the pointer! I've corrected the following: - {{#setSettings(Map)}} was removed as {{#setSetting(Properties)}} is totally fine in spring (ref: bean definition example in commented block in unit test). - Corrected logging in {{SpringResourceTemplateLoader}}. - Added {{VersionEditor}} for Spring because it's more convenient to set by string in XML bean definitions. (See "FooEditor" example in \[1\] for reference.) Since this PR includes {{VersionEditor}} in core, please take a review. Regards, Woonsan \[1\] https://docs.spring.io/spring/docs/current/spring-framework-reference/html/validation.html#beans-beans-conversion > FM3 freemareker-spring module, basic functionality > -------------------------------------------------- > > Key: FREEMARKER-54 > URL: https://issues.apache.org/jira/browse/FREEMARKER-54 > Project: Apache Freemarker > Issue Type: Task > Affects Versions: 3.0.0 > Reporter: Daniel Dekany > > Create the Gradle module. Basic non-Web functionality. This certainly means: > * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}} > which has defaults that are practical for Spring. > * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's > {{Resource}} abstraction > It's also an important goal to polish the {{freemarker-core}} configuration > and template loader API-s, and change them if that's needed for smoother > Spring integration. -- This message was sent by Atlassian JIRA (v6.4.14#64029)