I can add to both. On Sun, Oct 21, 2018 at 3:28 PM Darrel Schneider <[email protected]> wrote:
> *@dschneider-pivotal* requested changes on this pull request. > ------------------------------ > > In > geode-core/src/test/java/org/apache/geode/internal/cache/entries/AbstractRegionEntryTest.java > <https://github.com/apache/geode/pull/2676#discussion_r226881002>: > > > @@ -14,10 +14,13 @@ > */ > package org.apache.geode.internal.cache.entries; > > +import static org.apache.geode.internal.Assert.assertTrue; > > instead of modifying the AbstractRegionEntry unit test I think you should > modify or add a unit test for DiskStoreID. That is the class you are > modifying and it should make your test much simpler since you can just > directly test compareTo and demonstrate that it returns 0 for DiskStoreID > that are not equal. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/geode/pull/2676#pullrequestreview-166803721>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AKN7XkM0XuHauy81T4XWIsOMK1xmN1BVks5unPUogaJpZM4XySxo> > . > [ Full content available at: https://github.com/apache/geode/pull/2676 ] This message was relayed via gitbox.apache.org for [email protected]
