@galen-pivotal @aditya87 This already got merged but I have a few comments:

1) The new jars are all Apache licensed so that's good.  However, commons-math3 
has some declarations in the notice file that need to be considered and 
probably added to our NOTICE for binary dependencies.  See 
https://git-wip-us.apache.org/repos/asf?p=commons-math.git;a=blob;f=NOTICE.txt;h=12232535fdcecf37638dee76fc177a5ddb28de1e;hb=7ec508828f62c2a3df31cde2a2f3aa32c5135fdb

2) The new jars are included in the lib/ dir but not added to the classpath.  
Was this intended?  Did you test this from an integration test and/or 
command-line?

Thanks!

[ Full content available at: https://github.com/apache/geode/pull/2802 ]
This message was relayed via gitbox.apache.org for 
[email protected]

Reply via email to