This PR consists of two commits. First commit refactors FunctionService so that 
it is unit testable. Second commit removes PowerMock from the ExecuteFunction 
unit tests.
```
commit edf7d3c65892e0c3b05fdf25c4c2bfb1cd2bf23a (HEAD -> 
GEODE-6176-FunctionService-PowerMock, 
kirklund-fork/GEODE-6176-FunctionService-PowerMock)
Author: Kirk Lund <[email protected]>
Date:   Mon Dec 10 16:42:50 2018 -0800

    GEODE-6143: Remove PowerMock from ExecuteFunction tests
    
    Remove PowerMock from:
    * ExecuteFunctionTest
    * ExecuteFunction65Test
    * ExecuteFunction66Test
    
    Add test for ExecuteFunction70Test by subclasses ExecuteFunction66Test.
```
```
commit 0992c246577ba5a4c8b42d2c06974c1efcb1de60
Author: Kirk Lund <[email protected]>
Date:   Mon Dec 10 13:44:24 2018 -0800

    GEODE-6176: Make FunctionService testable with internal delegates
    
    Introduce new FunctionExecutionService interfaces:
    * FunctionExecutionService (User API)
    * InternalFunctionExecutionService
    
    Implement new interfaces with a traditional class to be instantiated:
    * FunctionExecutionServiceImpl
    
    Collapse FunctionServiceManager into FunctionExecutionServiceImpl
    
    Change static API classes to delegate to private instance of
    FunctionExecutionServiceImpl:
    * FunctionService (User API) -- only has private internal changes
    * InternalFunctionService -- now extends FunctionService
    
    This should allow unit tests to avoid using PowerMock.
```

[ Full content available at: https://github.com/apache/geode/pull/2982 ]
This message was relayed via gitbox.apache.org for 
[email protected]

Reply via email to