Due to different handling in the GatewaySenderEventRemoteDispatcher dispatcher and ack reader threads, it was possible for event processing to stop when a GemFireSecurityException was encountered by the ack reader connection retry logic.
This commit attempts to share common recoverable cases between the ack reader and dispatcher, while maintaining the cases which are specific to each. We also added a test which ensures that if a connection is denied due to invalid credentials upon a restart of the receiver, that the sender can recover if it again provides valid credentials. In the process, we removed a significant amount of duplicated and noisy code in the NewWanAuthenticationDUnitTests. Co-authored-by: Bill Burcham <[email protected]> Co-authored-by: Ryan McMahon <[email protected]> Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [X] Is your initial contribution a single, squashed commit? - [X] Does `gradlew build` run cleanly? - [X] Have you written or updated unit tests to verify your changes? - N/A If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to [email protected]. [ Full content available at: https://github.com/apache/geode/pull/3006 ] This message was relayed via gitbox.apache.org for [email protected]
