We should have a unit test for this new class. The main thing to test in that unit test is toData and fromData. I think the key thing to test is that the output of toData can be used as the input to fromData and the resulting changes made by fromData are equal to the original input of toData. This is not too hard. You can create a DataOutput that just writes to a byte array and then create a DataInput that reads from that byte array. You might want to add an equals method on this class or you could just ask info their maps are equal. Test toData with an empty map and a map with multiple entries.
[ Full content available at: https://github.com/apache/geode/pull/3032 ] This message was relayed via gitbox.apache.org for [email protected]
