Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
This removes use of Old-IO in peer-to-peer communications, enabling the use of SSL with New-IO Buffers and SocketChannels by way of the JDK's SSLEngine. The first commit is the original implementation. The second commit fixes the problems in that commit. If you've already reviewed the old code you can probably just look at the second commit. - position tracking for MsgReader has been moved into NioSslEngine and NioPlainEngine because the Ssl engine sometimes needs to allocate a new buffer and adjust the tracked read/process positions in the buffer - the same buffer expansion methods in Buffers was being used for read-side and write-side buffers but buffers being used for reads need to be handled differently than buffers being used for writing There is commented-out debugging code that I'll remove when these changes pass the Pull Request Stress Tests. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to [email protected]. [ Full content available at: https://github.com/apache/geode/pull/3075 ] This message was relayed via gitbox.apache.org for [email protected]
