Why is "makeReservation called from this sync block? I think it could be moved to after this block. I would also suggest refactoring the sync block into its own method "checkMemberDeparted". All it would need to have passed to it is "batch.getOwner" and it would throw. I think "has been departed" in the exception message is a bit awkward and it might be helpful to include the host's id in the message. How about "The transaction host " + batch.getOwner() + " is no longer a member of the cluster."
[ Full content available at: https://github.com/apache/geode/pull/3176 ] This message was relayed via gitbox.apache.org for [email protected]
