I don't think the "|| oldConnection.equals(c)" is needed. The caller has already borrowed oldConnection so it will not be found by findConnection. The previous code did not do this check so does a reason exist why it is needed now? It will not break anything but it does make the code more complicated, slows it down a bit, and could make someone think oldConnection might be in the deque
[ Full content available at: https://github.com/apache/geode/pull/3304 ] This message was relayed via gitbox.apache.org for [email protected]
