No one is using Admin API. It was deprecated before Apache Geode 1.0.0. I 
removed the logging of stack traces mainly because it's bad form for simple 
low-level utils like this to perform logging. The main reason to move this 
class out of admin.internal is because we're going to delete everything under 
admin.* but we have lots of code outside of admin.* using this class. I could 
add the logging back in if you feel strongly about it, but I don't think it's 
valuable.

If we change it further, then my preference would be to propagate the caught 
exception instead of logging it.

Current code does NOT include caught exceptions:
```
} catch (UnknownHostException e) {
  throw new AssertionError("Failed to get InetAddress: " + host);
}
```

Change to:
```
} catch (UnknownHostException e) {
  throw new AssertionError("Failed to get InetAddress: " + host, e);
}
```


[ Full content available at: https://github.com/apache/geode/pull/4020 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org

Reply via email to