Add javadocs for this class. It is an external api. I find the class confusing. 
I expected it to just be a map but instead it has self, list, and others. It is 
also not clear how the constants on this class are related to links.
It would be best for this to be an interface so that it could be read only.
We really don't intend for users to be calling any of these settors or 
constructors.
If we can't make it an interface then get rid of any of the settors that we 
can. For example get rid of addLink. We don't need it for our implementation. 
We can instead just call getOthers().put(key, url)

[ Full content available at: https://github.com/apache/geode/pull/4158 ]
This message was relayed via gitbox.apache.org for 
[email protected]

Reply via email to