DonalEvans commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r413387539



##########
File path: 
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/ClearRvvLockingDUnitTest.java
##########
@@ -51,7 +51,7 @@
 
 /**
  * Test class to verify proper RVV locking interaction between entry 
operations such as PUT/REMOVE
- * and the CLEAR region operation
+ * and the CLEAR_REGION region operation

Review comment:
       Another accidental rename.

##########
File path: 
geode-core/src/distributedTest/java/org/apache/geode/cache30/RegionReliabilityTestCase.java
##########
@@ -1341,7 +1341,7 @@ public void run() {
       // pass
     }
 
-    // CLEAR
+    // CLEAR_REGION

Review comment:
       I think that several of these renames were accidentally included when 
changing the Cli string. They should be put back how they were.

##########
File path: 
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java
##########
@@ -43,19 +43,20 @@
 import org.apache.geode.test.dunit.rules.DistributedRule;
 
 /**
- * Test class to verify proper locking interaction between transactions and 
the CLEAR region
+ * Test class to verify proper locking interaction between transactions and 
the CLEAR_REGION region

Review comment:
       More accidental renames in this file.

##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
##########
@@ -3509,7 +3509,7 @@ public String toString() {
       if (de != null) {
         sb.append(" key=").append(de.getKey());
       } else {
-        sb.append(" <END CLEAR>");
+        sb.append(" <END CLEAR_REGION>");

Review comment:
       Accidental rename.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to