demery-pivotal commented on a change in pull request #4977:
URL: https://github.com/apache/geode/pull/4977#discussion_r413425777
##########
File path: geode-pulse/build.gradle
##########
@@ -50,7 +50,9 @@ dependencies {
// Needed to fully use log4j instead of commons-logging.
implementation('org.apache.logging.log4j:log4j-jcl')
implementation('org.apache.logging.log4j:log4j-api')
-// implementation('org.apache.logging.log4j:log4j-core')
+ implementation('org.apache.logging.log4j:log4j-slf4j-impl') {
Review comment:
Okay. And probably it should be `runtimeOnly` instead of `implementation`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
