jujoramos commented on a change in pull request #4990: URL: https://github.com/apache/geode/pull/4990#discussion_r416534712
########## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/PingOpDistributedTest.java ########## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.internal.cache.tier.sockets; + +import static java.util.Arrays.asList; +import static org.apache.geode.internal.AvailablePortHelper.getRandomAvailableTCPPortsForDUnitSite; +import static org.apache.geode.test.dunit.VM.getVM; +import static org.assertj.core.api.Assertions.assertThat; + +import java.io.BufferedReader; +import java.io.File; +import java.io.FileReader; +import java.io.IOException; +import java.io.Serializable; +import java.util.Collections; +import java.util.List; + +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; + +import org.apache.geode.cache.client.ClientCacheFactory; +import org.apache.geode.cache.client.PoolFactory; +import org.apache.geode.cache.client.PoolManager; +import org.apache.geode.cache.client.internal.PingOp; +import org.apache.geode.cache.client.internal.PoolImpl; +import org.apache.geode.cache.server.CacheServer; +import org.apache.geode.distributed.internal.ServerLocation; +import org.apache.geode.distributed.internal.membership.InternalDistributedMember; +import org.apache.geode.test.awaitility.GeodeAwaitility; +import org.apache.geode.test.dunit.VM; +import org.apache.geode.test.dunit.rules.CacheRule; +import org.apache.geode.test.dunit.rules.ClientCacheRule; +import org.apache.geode.test.dunit.rules.DistributedRule; +import org.apache.geode.test.junit.rules.serializable.SerializableTemporaryFolder; +import org.apache.geode.test.junit.rules.serializable.SerializableTestName; + +public class PingOpDistributedTest implements Serializable { + + @Rule + public CacheRule cacheRule = new CacheRule(); + + @Rule + public ClientCacheRule clientCacheRule = new ClientCacheRule(); + + @Rule + public SerializableTestName testName = new SerializableTestName(); + + @Rule + public DistributedRule distributedRule = new DistributedRule(2); + + @Rule + public SerializableTemporaryFolder folder = new SerializableTemporaryFolder(); + + private VM client; + private VM server1, server2; + private int server1Port, server2Port; + private File clientLogFile; + + private void initServer(int serverPort) throws IOException { + cacheRule.createCache(); + CacheServer cacheServer = cacheRule.getCache().addCacheServer(); + cacheServer.setPort(serverPort); + + // "Disable" the auto-ping for the duration of this test. + cacheServer.setMaximumTimeBetweenPings((int) GeodeAwaitility.getTimeout().toMillis()); + cacheServer.start(); + } + + private void initClient(String poolName, List<Integer> serverPorts) { + final ClientCacheFactory clientCacheFactory = new ClientCacheFactory() + .set("log-file", clientLogFile.getAbsolutePath()); + clientCacheFactory.create(); + + PoolFactory poolFactory = PoolManager.createFactory(); + serverPorts.forEach(serverPort -> poolFactory.addServer("localhost", serverPort)); + + // "Disable" the auto-ping for the duration of this test. + poolFactory.setPingInterval((int) GeodeAwaitility.getTimeout().toMillis()); + poolFactory.create(poolName); + } + + @Before + public void setUp() throws IOException { + int[] ports = getRandomAvailableTCPPortsForDUnitSite(2); + + client = getVM(0); + server1 = getVM(1); + server2 = getVM(2); + server1Port = ports[0]; + server2Port = ports[1]; + server1.invoke(() -> initServer(server1Port)); + server2.invoke(() -> initServer(server2Port)); + + clientLogFile = folder.newFile("client-archive.log"); + + } + + void parametrizedSetUp(String poolName, List<Integer> serverPorts) { + client.invoke(() -> initClient(poolName, serverPorts)); + } + + public void executePing(String poolName, int serverPort, + InternalDistributedMember distributedMember) { + PoolImpl poolImpl = (PoolImpl) PoolManager.find(poolName); + PingOp.execute(poolImpl, new ServerLocation("localhost", serverPort), distributedMember); + } + + public Long getSingleHeartBeat() { + ClientHealthMonitor chm = ClientHealthMonitor.getInstance(); + assertThat(chm.getClientHeartbeats()).isNotEmpty().hasSize(1); + + return chm.getClientHeartbeats().entrySet().iterator().next().getValue(); + } + + @Test + public void regularPingFlow() { + final String poolName = testName.getMethodName(); + parametrizedSetUp(poolName, Collections.singletonList(server1Port)); + InternalDistributedMember distributedMember1 = (InternalDistributedMember) server1 + .invoke(() -> cacheRule.getCache().getDistributedSystem().getDistributedMember()); + + server1.invoke(() -> { + ClientHealthMonitor chm = ClientHealthMonitor.getInstance(); + assertThat(chm.getClientHeartbeats()).isEmpty(); + }); + + client.invoke(() -> executePing(poolName, server1Port, distributedMember1)); + Long firstHeartbeat = server1.invoke(this::getSingleHeartBeat); + + client.invoke(() -> executePing(poolName, server1Port, distributedMember1)); + Long secondHeartbeat = server1.invoke(this::getSingleHeartBeat); + + assertThat(secondHeartbeat).isGreaterThan(firstHeartbeat); + } + + @Test + public void memberShouldCorrectlyRedirectPingMessage() throws IOException { + final String poolName = testName.getMethodName(); + parametrizedSetUp(poolName, asList(server1Port, server2Port)); + InternalDistributedMember distributedMember1 = (InternalDistributedMember) server1 + .invoke(() -> cacheRule.getCache().getDistributedSystem().getDistributedMember()); + InternalDistributedMember distributedMember2 = (InternalDistributedMember) server2 + .invoke(() -> cacheRule.getCache().getDistributedSystem().getDistributedMember()); + + asList(server1, server2).forEach(vm -> vm.invoke(() -> { + ClientHealthMonitor chm = ClientHealthMonitor.getInstance(); + assertThat(chm.getClientHeartbeats()).isEmpty(); + })); + + System.out.println("########## FIRST PING START"); + client.invoke(() -> executePing(poolName, server1Port, distributedMember2)); + Long firstHeartbeatServer1 = server1.invoke(this::getSingleHeartBeat); + Long firstHeartbeatServer2 = server2.invoke(this::getSingleHeartBeat); Review comment: Yeah, do not worry about this particular test method, the one showing the issue is `memberShouldNotRedirectPingMessageWhenClientCachedViewIdIsWrong`. You can use the other two as starting points to develop your own tests for the `GEODE-7565`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
