sabbeyPivotal commented on a change in pull request #4989:
URL: https://github.com/apache/geode/pull/4989#discussion_r416633437
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/executor/hash/GeodeRedisHashSynchronized.java
##########
@@ -89,6 +89,11 @@ public int hdel(List<ByteArrayWrapper> subList) {
numDeleted.set(oldHash.size() - newHash.size());
return newHash;
});
+
+ if (hgetall().isEmpty()) {
+ RedisDataType type = context.getKeyRegistrar().getType(key);
Review comment:
Turns out the type was not getting checked for HDel, so we added a test
and updated the HDelExecutor. Thanks for pointing this out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
