albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r419179060
##########
File path:
geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache8_0.dtd
##########
@@ -675,6 +675,7 @@ As of 6.5 roll-oplogs is deprecated. Use disk-store-name
instead.
alert-threshold CDATA #IMPLIED
dispatcher-threads CDATA #IMPLIED
order-policy CDATA #IMPLIED
+ group-transaction-events (false | true) #IMPLIED
Review comment:
I finally figured out that it was not needed to change the dtd files.
But I had to change
CacheXmlGenerator so that the group-transaction-events attribute was not
added to the gateway sender in case the cache.xml version was older than Geode
1.0. Without this change, the following test cases were failing:
```
org.apache.geode.cache.CacheXml80GatewayDUnitTest >
testGatewaySenderWithSubstitutionFilter FAILED
org.apache.geode.cache.CacheXmlException: While reading Cache XML
file:/tmp/junit10230339244221650502/XML_8_0/CacheXml80GatewayDUnitTest_testGatewaySenderWithSubstitutionFilter.xml.
Error while parsing XML, caused by org.xml.sax.SAXParseException; lineNumber:
4; columnNumber: 458; Attribute "group-transaction-events" must be declared for
element type "gateway-sender".
org.apache.geode.cache.CacheXml70GatewayDUnitTest >
testParallelGatewaySender FAILED
org.apache.geode.cache.CacheXmlException: While reading Cache XML
file:/tmp/junit5316048290838435700/XML_7_0/CacheXml70GatewayDUnitTest_testParallelGatewaySender.xml.
Error while parsing XML, caused by org.xml.sax.SAXParseException; lineNumber:
4; columnNumber: 422; Attribute "group-transaction-events" must be declared for
element type "gateway-sender".
org.apache.geode.cache.CacheXml70GatewayDUnitTest > testSerialGatewaySender
FAILED
org.apache.geode.cache.CacheXmlException: While reading Cache XML
file:/tmp/junit13002812494872484215/XML_7_0/CacheXml70GatewayDUnitTest_testSerialGatewaySender.xml.
Error while parsing XML, caused by org.xml.sax.SAXParseException; lineNumber:
4; columnNumber: 423; Attribute "group-transaction-events" must be declared for
element type "gateway-sender".
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
