onichols-pivotal commented on a change in pull request #5040:
URL: https://github.com/apache/geode/pull/5040#discussion_r422415079
##########
File path:
geode-core/src/main/java/org/apache/geode/net/SSLParameterExtension.java
##########
@@ -29,9 +29,9 @@
/**
* Initialize the SSLParameterExtension.
*
- * @param config the DistributionConfig
+ * @param properties the Properties
*/
- default void init(DistributionConfig config) {}
+ default void init(Properties properties) {}
Review comment:
this is a breaking change on a public class that is not marked
@Experimental.
why not keep `init(DistributionConfig)` and just make it call
`init(distributionConfig.toProperties())` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
