Bill commented on a change in pull request #5116:
URL: https://github.com/apache/geode/pull/5116#discussion_r425911891
##########
File path: geode-membership/build.gradle
##########
@@ -38,9 +38,7 @@ dependencies {
//Jgroups is a core component of our membership system.
implementation('org.jgroups:jgroups')
- testImplementation(project(':geode-junit')) {
- exclude module: 'geode-logging'
- }
+ testImplementation(project(':geode-junit'))
Review comment:
each of these excludes was superfluous. the excludes were necessary in
other modules, where the exclusions broke what would have been circular
inter-module dependencies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
