davebarnes97 commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r426045897
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java
##########
@@ -60,12 +60,17 @@ public ResultModel query(
@CliOption(key = "file", help = "File in which to output the results.",
optionContext = ConverterHint.FILE) final File outputFile,
@CliOption(key = CliStrings.QUERY__INTERACTIVE, unspecifiedDefaultValue
= "false",
- help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive) {
- DataCommandResult dataResult = select(query);
+ help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive,
+ @CliOption(key = CliStrings.MEMBER,
+ optionContext = ConverterHint.MEMBERIDNAME,
+ help = CliStrings.QUERY__MEMBER__HELP) final String memberNameOrId) {
Review comment:
@DonalEvans I can add --member=value to the gfsh query command
description.
Not sure about removing --step-name and --file. Is it possible those are
present for legacy support (like, they used to be supported in earlier
versions, so need to be kept around?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
