jinmeiliao commented on a change in pull request #5102:
URL: https://github.com/apache/geode/pull/5102#discussion_r426211284
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java
##########
@@ -60,12 +60,17 @@ public ResultModel query(
@CliOption(key = "file", help = "File in which to output the results.",
optionContext = ConverterHint.FILE) final File outputFile,
@CliOption(key = CliStrings.QUERY__INTERACTIVE, unspecifiedDefaultValue
= "false",
- help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive) {
- DataCommandResult dataResult = select(query);
+ help = CliStrings.QUERY__INTERACTIVE__HELP) final boolean
interactive,
+ @CliOption(key = CliStrings.MEMBER,
+ optionContext = ConverterHint.MEMBERIDNAME,
+ help = CliStrings.QUERY__MEMBER__HELP) final String memberNameOrId) {
Review comment:
`--step-name` and `--interactive` can be removed in the docs since they
are not used by the command anymore, but they can NOT be removed in the option
list for backward compatibility reasons (user with old scripts might break).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
