kohlmu-pivotal commented on a change in pull request #5136:
URL: https://github.com/apache/geode/pull/5136#discussion_r428396768
##########
File path:
geode-modules/src/main/java/org/apache/geode/services/module/impl/JBossModuleService.java
##########
@@ -92,18 +98,20 @@ public boolean loadModule(ModuleDescriptor
moduleDescriptor) {
builder.addResourceRoot(ResourceLoaderSpec.createResourceLoaderSpec(resourceLoader));
}
} catch (IOException e) {
- logger.error(e);
+ logger.error(e.getMessage());
return false;
}
+
builder.addDependency(DependencySpec.createSystemDependencySpec(PathUtils.getPathSet(null)));
+
ModuleSpec moduleSpec = builder.create();
moduleLoader.addModuleSpec(moduleSpec);
try {
modules.put(moduleDescriptor.getVersionedName(),
moduleLoader.loadModule(moduleSpec.getName()));
} catch (ModuleLoadException e) {
- logger.error(e);
+ logger.error(e.getMessage());
Review comment:
Please print the stacktrace. so please revert back to `logger.error(e)`
##########
File path:
geode-modules/src/main/java/org/apache/geode/services/module/impl/JBossModuleService.java
##########
@@ -92,18 +98,20 @@ public boolean loadModule(ModuleDescriptor
moduleDescriptor) {
builder.addResourceRoot(ResourceLoaderSpec.createResourceLoaderSpec(resourceLoader));
}
} catch (IOException e) {
- logger.error(e);
+ logger.error(e.getMessage());
Review comment:
Please print the stacktrace. so please revert back to `logger.error(e)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
