bschuchardt commented on a change in pull request #5132:
URL: https://github.com/apache/geode/pull/5132#discussion_r428776911
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
##########
@@ -3027,13 +3027,17 @@ private void readMessage(ByteBuffer peerDataBuffer) {
failureMsg = "ClassNotFound deserializing message";
failureEx = ex;
rpId = md.getRPid();
- logger.fatal("ClassNotFound deserializing message: {}", ex.toString());
+ // log at info level first in case fatal-level alert notification
becomes blocked
+ logger.info(failureMsg, failureEx);
+ logger.fatal(failureMsg, failureEx.toString());
Review comment:
Beats me why the toString is there - I didn't add it. I do want to see
the full call stack when triaging a problem like this. Maybe it has to do with
alert listeners wanting one-liners?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
