pivotal-jbarrett commented on a change in pull request #5142:
URL: https://github.com/apache/geode/pull/5142#discussion_r429007050
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
##########
@@ -1943,6 +1931,36 @@
* <U>Default</U>: ""
*/
String REDIS_PASSWORD = "redis-password";
+ /**
+ * The static String definition of the <i>"redis-port"</i> property <a
name="redis-port"/a>
+ * </p>
+ * <U>Description</U>: Specifies the port used by Redis API for Geode which
enables Redis
+ * clients to connect and store data in GemFire distributed system. A value
of 0 will select a
+ * random port.
+ * </p>
+ * <U>Default</U>: "6379"
+ * </p>
+ * <U>Allowed values</U>: 0..65535
+ */
+ String REDIS_PORT = "redis-port";
+ /**
+ * The static String definition of the <i>"redis-service-enabled"</i>
property <a
+ * name="redis-service-enabled"/a>
+ * </p>
+ * <U>Description</U>: When the default value of false, the Redis API for
Geode is not available.
+ * Set to true to enable the Redis API for Geode.</td>
+ * </p>
+ * <U>Default</U>: false
+ * <td>redis-service-enabled</td>
+ * <td>When the default value of false, the Redis API for
<%=vars.product_name%> is not available.
+ * Set
+ * to true to enable the Redis API for <%=vars.product_name%>.</td>
+ * <td>S</td>
+ * <td>false</td>
+ * </tr>
+ * </p>
+ */
+ String REDIS_SERVICE_ENABLED = "redis-service-enabled";
Review comment:
Why add in the word "service" here? Why not just "redis-enabled". None
of the other redis properties use the word "service". I think consistent naming
conventions are really important to avoid confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
