bschuchardt opened a new pull request #5172: URL: https://github.com/apache/geode/pull/5172
The JMX tests in this test class use "localhost" to connect to a Manager. This is being transformed somehow into an IP numeric address and is failing endpoint verification. The test passes on my Windows machine and also passes on Mac and Ubuntu when I run it there. I'm adding the "localhost" IP address to the certificate to get past this. Another fix would be to change the Rule that's using "localhost" to use the real host name but that would affect a lot of other tests. Before I started messing with this test it was adding InetAddress.getLocalHost() as an IP address to the certificate so I don't think this is a big change to the original test. The test now uses LocalHostUtils.getLocalHost() to get an IP to add to the certificate, which is the correct "localhost" to use with Geode. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
