davebarnes97 commented on a change in pull request #5214:
URL: https://github.com/apache/geode/pull/5214#discussion_r436181874
##########
File path: geode-book/master_middleman/source/subnavs/geode-subnav.erb
##########
@@ -2197,6 +2197,9 @@ gfsh</a>
<li>
<a
href="/docs/guide/<%=vars.product_version_nodot%>/tools_modules/redis_api_for_geode.html#advantages-of-<%=vars.product_name_lowercase%>-over-redis">Advantages
of <%=vars.product_name%> over Redis</a>
Review comment:
Not part of this PR, but a potential problem. We use template variables
to allow portability to other products that use the geode open-source repo. Use
in section names (such as "Advantages of <%=vars.product_name%>..." follows
this intention. However, use in target ids (such as
"#advantages-of-<%=vars.product_name_lowercase%>-over-redis") defeats the
purpose, as the links are almost certainly guaranteed to fail in other
contexts. The anchor tags should be genericized, for example
"advantages-over-redis".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
