jujoramos commented on a change in pull request #5227:
URL: https://github.com/apache/geode/pull/5227#discussion_r440361325
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/management/MemberMXBeanDistributedTest.java
##########
@@ -82,16 +82,19 @@ public void testBucketCount() {
server3.invoke(() -> createBuckets(regionName));
server4.invoke(() -> createBuckets(regionName));
- await().untilAsserted(() -> {
- final int sumOfBuckets = server1.invoke(() -> getBucketsInitialized()) +
- server2.invoke(() -> getBucketsInitialized()) +
- server3.invoke(() -> getBucketsInitialized()) +
- server4.invoke(() -> getBucketsInitialized());
- assertEquals("Expected bucket count is 1000, and actual count is " +
sumOfBuckets,
- sumOfBuckets, 1000);
- });
-
for (int i = 1; i < 4; i++) {
+
+ final int index = i;
+ await().untilAsserted(() -> {
+ final int sumOfBuckets = server1.invoke(() -> getBucketsInitialized())
+
+ server2.invoke(() -> getBucketsInitialized()) +
+ server3.invoke(() -> getBucketsInitialized()) +
+ server4.invoke(() -> getBucketsInitialized());
+ final int expectedBuckets = index * 1000;
+ assertThat(sumOfBuckets).isEqualTo(expectedBuckets);
+
+ });
Review comment:
The change to wait within the loop might help, I'm not arguing that, but
I still don't think that it will fix the flakiness; it also clutters the test
class a lot.
I believe the proper fix would be to force the bucket creation
(`PartitionRegionHelper.assignBucketsToPartitions`) within the loop after each
region is created, as you're already doing for the initial region
(`testCreateRegion`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
