bschuchardt opened a new pull request #5265: URL: https://github.com/apache/geode/pull/5265
Use of SSLEngine with NIO has proven to be less robust than using "old-io" SSLSockets. This draft PR reintroduces SSLSockets into cluster communications for performance and functional testing. The structure of the org.apache.geode.internal.tcp package is left intact. None of the old code including Connection.runNioReader() has been brought back. Code differences between use of NIO and OIO are minimal and are at the socket-read/socket-write level. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
