mhansonp commented on a change in pull request #5271:
URL: https://github.com/apache/geode/pull/5271#discussion_r441853889
##########
File path: ci/bin/concourse_job_performance.py
##########
@@ -58,7 +60,7 @@ def main(url, team, pipeline, job, number_of_builds,
authorization_cookie, threa
builds = get_builds_summary_sheet(url, team, pipeline, job,
number_of_builds+10, authorization_cookie)
build_to_examine = get_builds_to_examine(builds, number_of_builds)
- expected_failed_builds = [int(b['name']) for b in build_to_examine if
b['status'] == 'failed']
+ expected_failed_builds = [int(b['name']) for b in build_to_examine if
b['status'] in ['failed', 'succeeded']]
Review comment:
You might want to rename the variable if now you are looking at failed
and succeeded builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
