pdxcodemonkey commented on pull request #619:
URL: https://github.com/apache/geode-native/pull/619#issuecomment-646633422
As an experiment, I made the following change this morning:
```
TEST(PdxJsonTypeTest, testTwoObjectsWithSameFieldsHaveTheSameHash) {
// Cluster cluster{LocatorCount{1}, ServerCount{1}};
// cluster.start();
// cluster.getGfsh()
// .create()
// .region()
// .withName("region")
// .withType("REPLICATE")
// .execute();
//
// auto cache = cluster.createCache();
//
// auto properties = std::make_shared<Properties>();
// CacheImpl cacheImpl(&cache, properties, false, false, nullptr);
PdxTypeRegistry pdxTypeRegistry(nullptr);
(...)
```
Since the new tests don't hit any code that dereferences the type registry,
this worked, and the test(s) passed. This would allow the hash tests to be
moved to the _unit_ test suite, where you have access to internal headers, and
we wouldn't have to expose `apache::geode::client::PdxType` from the library.
@pivotal-jbarrett , thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
