pivotal-jbarrett commented on a change in pull request #619:
URL: https://github.com/apache/geode-native/pull/619#discussion_r443596357
##########
File path: cppcache/benchmark/CMakeLists.txt
##########
@@ -19,12 +19,15 @@ add_executable(cpp-benchmark
GeodeHashBM.cpp
GeodeLoggingBM.cpp
NoopBM.cpp
- )
+ PdxTypeBM.cpp)
+
+#add_dependencies(integration-framework)
target_link_libraries(cpp-benchmark
PUBLIC
apache-geode-static
benchmark::benchmark
+ integration-framework
Review comment:
Don't add this here. There is an cppcache/integration/benchmark already.
Move the benchmark to the integration benchmark directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
