jujoramos commented on a change in pull request #5303:
URL: https://github.com/apache/geode/pull/5303#discussion_r445504922
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
##########
@@ -129,7 +130,9 @@ public void testPingWrongServer() {
PingOp.execute(pool, new ServerLocation(NetworkUtils.getServerHostName(),
PORT1), server2ID);
// if the ping made it to server2 it will have the client's ID in its
health monitor
server2.invoke(() -> {
- assertEquals(1,
ClientHealthMonitor.getInstance().getClientHeartbeats().keySet().size());
+ await("For heartbeat to be received").timeout(Duration.ofMinutes(1))
Review comment:
I agree in that 5 minutes might be "too much" for this test, but it's
the current standard and there are only a handful of tests (8 I think) that
overrides it, so I think is better to keep using the defaults for everything
new.
As a side note, the poll occurs every 100 milliseconds anyway, so the
condition should be met way sooner than 5 minutes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
