pivotal-eshu commented on a change in pull request #5256:
URL: https://github.com/apache/geode/pull/5256#discussion_r445823337
##########
File path:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
##########
@@ -242,12 +252,15 @@ public void setAttribute(String name, Object value,
boolean notify) {
checkBackingCacheAvailable();
- synchronized (this.changeLock) {
+ synchronized (changeLock) {
// Serialize the value
byte[] serializedValue = serialize(value);
// Store the attribute locally
- if (this.preferDeserializedForm) {
+ if (preferDeserializedForm) {
+ if (notify) {
Review comment:
This seems unnecessary, as the next line code (super.setAttribute(name,
value, true);) would override and set the attribute value again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
