kirklund commented on a change in pull request #5309:
URL: https://github.com/apache/geode/pull/5309#discussion_r445903215
##########
File path:
geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java
##########
@@ -145,9 +145,7 @@ public GfshExecution execute(GfshScript gfshScript, File
workingDir) {
public GfshExecution execute(GfshScript gfshScript) {
try {
- File workingDir = new File(temporaryFolder.getRoot(),
gfshScript.getName());
- workingDir.mkdirs();
- return execute(gfshScript, workingDir);
+ return execute(gfshScript, temporaryFolder.getRoot());
Review comment:
Note: The workingDir for gfshScript is the workingDir for the GFSH
process spawned by the JUnit test. GFSH then spawns the Locator and Server
which is running in a subfolder. This change makes it easy for GfshRule to stop
ALL Locators and Servers anywhere in the TemporaryFolder. Since only one
gfshScript is executed at a time, the GFSH workingDir should be ok as
temporaryFolder.getRoot().
On the off-chance that this does cause a problem, it would have to be for
other GFSH commands that write something to the current workingDir of GFSH. I'm
fairly confident we don't have tests that will have disk artifacts colliding
just because of this little change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
