dschneider-pivotal commented on a change in pull request #5320: URL: https://github.com/apache/geode/pull/5320#discussion_r450315786
########## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/SingleResultRedisFunction.java ########## @@ -64,11 +61,4 @@ public boolean optimizeForWrite() { public boolean isHA() { return true; } - - public static void computeWithPrimaryLocked(Object key, LocalDataSet localDataSet, Runnable r) { Review comment: Yes. If, in the future, we have an operation that needs the LocalDataSet then we can pass it to that operation explicitly. I moved RenameFunction.getLocalDataSet ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org