[GitHub] [geode] Bill edited a comment on pull request #5344: GEODE-8330: Structural Improvements to Versioning

[GitBox]

Bill edited a comment on pull request #5344:
URL: https://github.com/apache/geode/pull/5344#issuecomment-654963614


   The DistributedTestOpenJD11 failure is due to 
https://issues.apache.org/jira/browse/GEODE-7710
   
   @bschuchardt to your point about `getKnownVersion()` calls not being 
understandable: what if the signature was changed to be more like the JDK's 
`Map.getOrDefault(Object key, V defaultValue)`? Something like:
   
   ```java
   getKnownVersionOrDefault(final short ordinal, final Version 
defaultKnownVersion)
   ```
   
   That gives rise to call sites that look like:
   
   <img width="1081" alt="image" 
src="https://user-images.githubusercontent.com/4002/86813144-a65a7580-c034-11ea-9a23-77ecf56858ad.png";>
   
   <img width="771" alt="image" 
src="https://user-images.githubusercontent.com/4002/86813078-95116900-c034-11ea-8478-701f8fbee394.png";>
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org