bschuchardt opened a new pull request #5363: URL: https://github.com/apache/geode/pull/5363
Use of SSLEngine with NIO has proven to be less robust than using "old-io" SSLSockets. This PR reintroduces SSLSockets into cluster communications and removes the use of "new IO" SSLEngine as an option. The structure of the org.apache.geode.internal.tcp package is left intact. None of the old code including Connection.runOioReader() has been brought back. Code differences between use of NIO and OIO are minimal and are mostly at the socket-read/socket-write level. The MsgReader class is modified to handle buffer manipulation that was in the previous "old IO" implementation but was delegated to the "filter" implementation prior to this PR. Performance testing has shown that serialization and transmission of messages works best with "direct" memory buffers while the reading of messages with SSL functions best with "heap" memory buffers. DirectChannel and DirectReplyProcessor reflect the choice of "direct" memory buffers for writing while ClusterConnection's inputBuffer reflects the choice of "heap" memory buffers for reading. There are a few changes to the NIO "engine" implementations that I made while testing performance that I decided to keep because they allow the use of NioPlainEngine with SSLSockets. That could be an advantage when performing similar work in client/server communications. The cluster communications class has been renamed to ClusterConnection because I'm very tired of the client/server Connection class having the same name. Every time I try to open the class with IntelliJ it recommends the client/server class as the first option. No more! Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to [email protected]. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
