Bill commented on a change in pull request #5370:
URL: https://github.com/apache/geode/pull/5370#discussion_r455891914
##########
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberData.java
##########
@@ -507,8 +507,8 @@ public void setVmKind(int vmKind) {
@Override
- public void setVersion(Version v) {
- setVersionOrdinal(v.ordinal());
+ public void setVersion(VersionOrdinal versionOrdinal) {
+ setVersionOrdinal(versionOrdinal.ordinal());
Review comment:
Let's set `versionOrdinal` (object reference) directly here and
eliminate `MemberData.setVersionOrdinal(short)` entirely. The method shouldn't
exist at all. We should not be passing a `short` ordinal to a `MemberData`.
There are three places `MemberData.setVersionOrdinal(short)` is called:
1. here: just set the field directly
2. `readEssentialData()`: replace
`setVersionOrdinal(VersioningIO.readOrdinal(in));` with `setVersion(Versioning.
getVersionOrdinal(VersioningIO.readOrdinal(in)))`
3. `GMSMemberDataVersionJUnitTest.testSetVersionOrdinal()`: delete this test
method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
