bschuchardt commented on a change in pull request #130:
URL: https://github.com/apache/geode-benchmarks/pull/130#discussion_r456533721
##########
File path:
geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/GeodeBenchmark.java
##########
@@ -45,11 +46,20 @@ public static TestConfig createConfig() {
config.durationSeconds(BENCHMARK_DURATION);
config.threads(THREADS);
- final String sniProp = System.getProperty("withSniProxy");
- final boolean doSni = sniProp != null && !sniProp.equals("false");
+ String prop = System.getProperty("withSniProxy");
Review comment:
Hmm, that's as may be but the code you wrote doesn't do the same thing
as Boolean.getBoolean(). The code allows the property to be set with a value
that, if not "false", enables the setting. Boolean.getBoolean() returns
`false` if the property is not set or if it is set but is not exactly equal to
"false".
Changing the code to use Boolean.getBoolean() causes your test
GeodeBenchmarkTest.withSniProxyNotLowercaseFalse to fail, so I'd like some
assurance that it's okay to delete that test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
