jinmeiliao commented on a change in pull request #5348:
URL: https://github.com/apache/geode/pull/5348#discussion_r465905356
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java
##########
@@ -180,6 +180,9 @@
protected volatile ConcurrentLinkedQueue<EntryEventImpl> tmpDroppedEvents =
new ConcurrentLinkedQueue<>();
+
+ private volatile boolean mustQueueDroppedEvents = true;
Review comment:
maybe rename it to be queueTempDroppedEvent
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java
##########
@@ -155,4 +160,38 @@ public ResultModel startGatewaySender(@CliOption(key =
CliStrings.START_GATEWAYS
return resultModel;
}
+
+ private boolean sendAllStartingMessage(Set<DistributedMember> dsMembers,
Cache cache,
Review comment:
I wonder why you are doing it through JMX, have you tried having a
function to turn on/off this flag and just execute that function on the other
members? That's a common way to tell members to do something
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
