pivotal-jbarrett commented on a change in pull request #5427:
URL: https://github.com/apache/geode/pull/5427#discussion_r466022409



##########
File path: ci/scripts/execute_tests.sh
##########
@@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then
   exit 1
 fi
 
+. ${SCRIPTDIR}/short_circuit_pr_tasks.sh
+cd geode
+  is_source_from_pr_testable "ci" "dev-tools" "etc" "geode-book" "geode-docs" 
|| exit 0

Review comment:
       Is it necessary to have the arguments at all given that they are the 
same in every call? Seems you could whittle this down to a single line 
`${SCRIPTDIR}/short_circuit_pr_tasks.sh && exit 0`, where 
`short_circuit_pr_tasks.sh` returns true if it should short circuit. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to