pivotal-jbarrett commented on a change in pull request #634:
URL: https://github.com/apache/geode-native/pull/634#discussion_r473106328
##########
File path: clicache/src/PoolFactory.hpp
##########
@@ -279,6 +279,20 @@ namespace Apache
/// </exception>
PoolFactory^ AddServer(String^ host, Int32 port);
+ /// <summary>
+ /// Set proxy info for SNI connection.
+ /// </summary>
+ /// <remarks>
+ /// Used for connecting via SNI proxy.
+ /// </remarks>
+ /// <param>
+ /// host the host name or ip address that the server is listening on.
+ /// </param>
+ /// <param>
+ /// port the port that the server is listening on.
+ /// </param>
+ PoolFactory^ SetSniProxy(String^ hostname, Int32 port);
Review comment:
So why not provide, like the Java API, an interface that can take
pre-canned `SocketFactory` classes. At this point the only deviation would be
the ability for users to provide their own factories?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
