jujoramos commented on a change in pull request #5175:
URL: https://github.com/apache/geode/pull/5175#discussion_r472878920
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java
##########
@@ -2318,7 +2318,7 @@ void close(boolean destroy) {
} catch (RuntimeException e) {
rte = e;
}
- if (!isOffline()) {
Review comment:
Wouldn't it be better to change the `DiskStoreImpl` constructor to only
instantiate the `AsyncFlusherThread` whenever we are not online instead?, that
would address the issue and make the class consistent, right?.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
