jujoramos commented on a change in pull request #5466:
URL: https://github.com/apache/geode/pull/5466#discussion_r474009698
##########
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
##########
@@ -519,6 +520,25 @@ public void
offlineDiskStoreCommandShouldNotCreateFolderIfDiskStoreDoesNotExist(
assertThat(Files.exists(nonExistingDiskStorePath)).isFalse();
}
+ @Test
+ @Parameters({"compact offline-disk-store", "describe offline-disk-store",
+ "upgrade offline-disk-store", "validate offline-disk-store",
+ "alter disk-store --region=testRegion --enable-statistics=true"})
+ public void offlineDiskStoreCommandShouldNotPassIfDiskStoreFileDoesNotExist(
Review comment:
Can you use change the test name to something more meaningful?, maybe
`offlineDiskStoreCommandShouldFailWhenDiskStoreFileDoesNotExist`?.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
